build: Don't install @edx/studio-frontend - #37484
Merged
Merged
Conversation
|
Sandbox deployment successful 🚀 |
Contributor
Author
|
There is still one component in the old unit editor that uses a component from studio-frontend, so we can't move forward with this one until #35261 is done. |
feanil
force-pushed
the
feanil/drop_assets_and_files
branch
from
October 16, 2025 19:07
2e5e575 to
da37eaa
Compare
feanil
force-pushed
the
feanil/drop_studio_frontend_dependency
branch
2 times, most recently
from
October 16, 2025 19:26
a703c1b to
83d2cd6
Compare
feanil
marked this pull request as ready for review
October 17, 2025 13:53
Contributor
Author
|
The last component that was using the studio frontend has now been removed also so this should be safe to land! |
feanil
force-pushed
the
feanil/drop_assets_and_files
branch
from
October 20, 2025 14:32
8af1c4c to
f84341f
Compare
feanil
force-pushed
the
feanil/drop_studio_frontend_dependency
branch
from
October 20, 2025 14:33
83d2cd6 to
2c75b23
Compare
kdmccormick
approved these changes
Oct 20, 2025
kdmccormick
left a comment
Member
There was a problem hiding this comment.
Pending a green build and some smoke testing, this looks good to me! 🔥 🔥 🔥
1 similar comment
feanil
force-pushed
the
feanil/drop_assets_and_files
branch
from
October 20, 2025 15:50
f84341f to
fcfa413
Compare
Contributor
Author
|
Smoke testing looks good, I'll merge this later today after the last PR it depends on has landed on |
Drop tooling to load studio-frontend components into mako templates and XSS testing features related to it.
feanil
force-pushed
the
feanil/drop_studio_frontend_dependency
branch
from
October 20, 2025 18:08
2c75b23 to
28ab2ce
Compare
feanil
enabled auto-merge
October 20, 2025 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependencies on this package via studio should all be removed now
and so we no longer need to install this package to pickup any
components from it.
This work is part of: